Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade React Native to v72.4 #7106

Merged
merged 14 commits into from
Mar 3, 2024
Merged

Upgrade React Native to v72.4 #7106

merged 14 commits into from
Mar 3, 2024

Conversation

drewvolz
Copy link
Member

@drewvolz drewvolz commented Mar 3, 2024 •
edited
Loading

Target branch is drew/xcode-15

Dependencies

  • bump react-native-async-storage to 1.19.3
  • bump react-native-reanimated to 3.7.2
  • bump metro-react-native-babel-preset to 0.76.8
  • add @react-native/eslint-config ^0.72.2
  • add @react-native/metro-config ^0.72.11
  • add @tsconfig/react-native ^3.0.0

Dependency overrides

  • override eslint-plugin-prettier to v5.1.3 (over @react-native/eslint-config's ^4.2.1)

Config

  • set node engines >=18
  • remove react-native/Libraries/Blob/FileReader.js patch

Gems

  • bump cocoapods 1.15.2
  • bump xcodeproj 1.24.0
  • bump fastlane 2.216.0

Links

@drewvolz
bump react-native to 0.72.4
547fe53 
configs
- merge metro configs
- set jest preset to react-native
- podfile config changes for hoisting with node

dependencies
- bump metro-react-native-babel-preset to 0.76.8
- add @react-native/eslint-config  ^0.72.2
- add @react-native/metro-config ^0.72.11
- add @tsconfig/react-native ^3.0.0
- set node engines >=18
@drewvolz
remove react-native/Libraries/Blob/FileReader.js patch
26f36cb
@drewvolz
bump react-native-reanimated to 2.17.0
5b678e0 
- working for android
- broken for iOS, tracking react-native-reanimated/issues/4522
@drewvolz
bump react-native-async-storage to 1.19.3
d65929e
@drewvolz
Merge branch 'master' into drew/react-native-72-4
5445893
@drewvolz
bump react-native-reanimated to 3.7.2
b10ece8
@drewvolz
upgrade xcodeproj and fastlane gems
a6806e0 
* xcodeproj 1.24.0
* fastlane 2.216.0
@drewvolz drewvolz requested review from hawkrives and rye as code owners March 3, 2024 00:04
@drewvolz drewvolz changed the title Upgrade React Native to v72 4 Upgrade React Native to v72.4 Mar 3, 2024
@drewvolz
Copy link
Member Author

drewvolz commented Mar 3, 2024 •
edited
Loading

  • This fails at the same point as Upgrade Xcode, macOS, iOS targets #7104 which is understandable.
  • Code signing issues being the only blocker which we can bypass with ci/skip-detox
  • Current failure is with gradle building for release (I think this was resolved by d8e90aa, 774b91c, and many cache CI deletions) 
    > ./gradlew bundleRelease

Task :app:mapReleaseSourceSetPaths FAILED
FAILURE: Build failed with an exception.

Execution failed for task ':app:mapReleaseSourceSetPaths'.
Querying the mapped value of map(flatmap(provider(task 'createBundleReleaseJsAndAssets', class      
com.facebook.react.tasks.BundleHermesCTask))) before task ':app:createBundleReleaseJsAndAssets' has completed  
is not supported

@drewvolz drewvolz mentioned this pull request Mar 3, 2024
Merged
@drewvolz drewvolz added the ci/skip-detox bypass issues with detox or code signing label Mar 3, 2024
@rye rye merged commit 33cc0f3 into drew/xcode-15 Mar 3, 2024
19 checks passed
@rye rye deleted the drew/react-native-72-4 branch March 3, 2024 19:04
@drewvolz drewvolz mentioned this pull request Mar 3, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rye rye rye approved these changes

@hawkrives hawkrives hawkrives approved these changes

Assignees
No one assigned
Labels
ci/skip-detox bypass issues with detox or code signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewvolz @hawkrives @rye